In that case, is there any way I’d be able to run your repo locally? That way I can symlink a dev version of the feathery react library and add logging
Unfortunately not… we have way too many dependencies for it to be run locally by you.
And unfortunately, the latest version 2.0.132
still doesn’t change the behavior. We only see our Onboarding Survey Viewed
amplitude event fired by our code which is embedding the feathery form, and not any of the amplitude events fired by the form itself.
That event that fires DOES correctly have the right user ID and device ID that we expect so when the page is first loaded amplitude is working as expected.
However:
- After the page loads the feathery form, running
window.amplitude
returns an object still (good!). But runningwindow.amplitude.getUserId()
orwindow.amplitude.getDeviceId()
returns null in both cases (bad!) - On any other page within our app, running those same console commands returns device and User IDs as expected, including whe the page is initially loaded as I mentioned.
So it seems like something is wrong with the scenario where we are embedding and the interplay between our instance of amplitude and yours.
Could you check if the invoked
flag gets set properly on your amplitude window object?
Also, do you still want Feathery to identify the user in the case where you guys have an existing amplitude installation? If not, I could skip that operation as well when an existing installation is detected
Yep it is:
Actually no, we don’t need that. If we have an amplitude installation and pass you a user ID, then it’s not necessary. Perhaps that should be an integration option?
You already can toggle on or off user ID identification from the Amplitude integration settings in your dashboard. (you requested this earlier)
For clarification: Previously when we discussed, I had 2 things in mind:
- Being able to pass in our own user ID so it wasn’t auto generated and still firing an amplitude
identify
call. - Not passing in a user ID but also not getting one autogenerated, and not firing
identify
either.
Case #2 is great for when you are piggybacking off an existing amplitude integration. In that case, we would have already identified the user, so new events fired client side would just inherit the existing amplitude context for that user.
Yes, 2 is now the behavior when we detect an existing amplitude integration.
Based on our call, we made one more fix in the latest embed library version. Can you try that out?
looks like that fixed it!! All errors gone, form loading in correctly, and i’m seeing the events come through in our amplitude! Thank youuuu!!
that’s great to hear!